Skip to content

Add quality selector for progressive download videos #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

joneug
Copy link
Contributor

@joneug joneug commented Feb 14, 2025

This patch adds the paella-mp4multiquality-plugin to bring back the quality selector for progressive download videos known from Paella Player 6. It also updates NPM dependencies to the versions used in the engage-paella-player-7 Opencast module. Lastly, I ran npm audit fix to let it fix vulnerabilities.

Changes are analogous to:

See also:

This patch adds the `paella-mp4multiquality-plugin` to bring
back the quality selector for progressive download videos
known from Paella 6. It also update the dependencies to the
versions used in the `engage-paella-player-7` Opencast module.
Lastly, I ran `npm audit fix` to let it fix vulnerabilities.

Changes are analogous to:
* opencast/opencast#5685
* elan-ev/tobira#1143

See also:
* polimediaupv/paella-core#352
* https://github.com/polimediaupv/paella-mp4multiquality-plugin
@bluetom bluetom requested a review from ferishili February 17, 2025 09:32
@ferishili
Copy link
Contributor

ferishili commented Feb 17, 2025

Hi @joneug, thanks for your contribution!
Is there a specific reason that the paella libraries are set to slightly older versions, for example:

  • "paella-core": "^1.49.7" but the latest release is currently 1.50.2
  • "paella-slide-plugins": "^1.48.1",, but the latest is currently. 1.50.1

I would suggestion to upgrade to the latest releases now that we are upgrading!

@joneug
Copy link
Contributor Author

joneug commented Feb 17, 2025

I updated all NPM dependencies to the latest minor version. There are some webpack-related dependencies that could be updated to a newer major version. However, I don't know whether this will break something in Paella.

Copy link
Contributor

@ferishili ferishili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes,
However, the paella-mp4multiquality-plugin plugin has been removed accidentally!

@ferishili ferishili self-requested a review February 18, 2025 12:58
@ferishili
Copy link
Contributor

Changes work as expected!
@bluetom please proceed with this issue!
Thanks in advance

@bluetom bluetom merged commit 852b167 into Opencast-Moodle:main Feb 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants